Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement lifecycle for Jena/Sesame/Etc #289

Open
antonkulaga opened this issue Jun 25, 2015 · 0 comments
Open

Implement lifecycle for Jena/Sesame/Etc #289

antonkulaga opened this issue Jun 25, 2015 · 0 comments

Comments

@antonkulaga
Copy link
Contributor

I see that lifecycle is not implemented anywhere. I think that possible Sesame implementation is

implicit val repositoryLifecycle:Lifecycle[Rdf, Sail] = new Lifecycle[Rdf,Sail] {

    override def start(sail:Sail): Unit = sail.initialize()

    override def stop(sail:Sail): Unit = sail.shutDown()
  }

But in such case we should change how GraphStoreTest works. Not it is something like:

class SesameMemoryGraphStoreTest extends SesameGraphStoreTest({
  val repo = new SailRepository(new MemoryStore)
  repo.initialize()
  repo.getConnection()
})

Here you pass connection to the test and consider the connection to be an RdfStore. But in case of start/stop we should also pass sail and apply lifecycle to sail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant