Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace {response_name}_mean with {response_name}_{parent_name}. #792

Open
tomicapretto opened this issue Mar 30, 2024 · 2 comments
Open

Comments

@tomicapretto
Copy link
Collaborator

Because of historical reasons, Bambi is always calling the parent of all families "mean". Given the flexibility we have now, e.g. distributional models for arbitrary likelihoods, I think it does not make sense to keep using "mean", and actually it can lead to confusion.

I think we can simply use the name of the parameter. For Normal likelihoods, it will be mu, for Bernoulli and Binomial it will be p, etc. etc.

@tomicapretto
Copy link
Collaborator Author

I'm also starting to think it's a good chance to change the dimension name for the observation index.

Right now we use {response_name}_obs and it has two drawbacks:

  1. We have to build the name every time we want to use it
  2. The name can be something not easy to read such as c(category 1, category 2, cat 3)_obs or p(y, n)_obs or censored(x, value)_obs.

I think we can always use the same name. Something like obs_idx, _obs_idx, __idx, obs_index, etc.

@tomicapretto
Copy link
Collaborator Author

There's more. What if we stop pre-pending the LHS of the formula to the name of the parameter? Right now it leads to something like p(y, n)_mean. If we use the name of the parameter it will be p(y, n)_p. What if we drop whatever we have on the RHS and start using parameter names? Simply mu, sigma, p, alpha, etc. etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant