Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new ICAR distribution #718

Open
lemartinet opened this issue Sep 9, 2023 · 2 comments
Open

Support new ICAR distribution #718

lemartinet opened this issue Sep 9, 2023 · 2 comments

Comments

@lemartinet
Copy link

Hi Tomas!
I was wondering if the new ICAR model that was added in pymc 5.8 could be potentially supported in Bambi, or if the current architecture would not be able to handle this.
Thanks for your thoughts!
Manu

@tomicapretto
Copy link
Collaborator

Hi Manu! Thanks for opening the issue.

I don't think it's impossible but:

  • I see pm.ICAR asks for an adjacency matrix. What should be the syntax to specify that in Bambi? As columns of a dataframe it could be very tedious and unpractical.
  • How should we treat the centered/non-centered parametrization? I think Bambi should automatically handle this under the hood. But, how do we do it? I guess we need a wrapper on top of the PyMC distribution, or some kind of special treatment, to automatically get mu out of phi and sigma depending on the case. I think it would be the first time we do something like this.

I can't promise anything but I'll be thinking about this.

@lemartinet
Copy link
Author

Thanks for sharing your thoughts on that, it's helpful to understand what's needed under the hood!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants