Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F-Droid build failed #98

Closed
linsui opened this issue May 11, 2024 · 16 comments
Closed

F-Droid build failed #98

linsui opened this issue May 11, 2024 · 16 comments

Comments

@linsui
Copy link

linsui commented May 11, 2024

Firebase is non-free. Is it used for Android?

@balzack
Copy link
Owner

balzack commented May 11, 2024

I use it only in the android build, I must have made an error in my merge of common features. I will look now

@balzack
Copy link
Owner

balzack commented May 11, 2024

@linUI, i think i accidentally tagged my android branch in the release instead of the fdroid branch.

I am sorry for the trouble, the latest release now is tagged from the fdroid branch.

@licaon-kter
Copy link

licaon-kter commented May 13, 2024

@balzack I'm testing https://github.com/balzack/databag/releases/tag/V1.1.13b now

but not sure how to proceed with autoupdates as the previous (broken one) Tag versionCode is waaaay higher and checkupdate will just say there's no newer one https://github.com/balzack/databag/blob/v1.1.13/app/mobile/android/app/build.gradle#L107

eg. maybe tag the fdroid versions differently -fdroid or next version bring fdroid versioncode at the same value?

@balzack
Copy link
Owner

balzack commented May 13, 2024

Could I increment the minor number to resolve this? (1.2)

With android I use the version code as a build number, which is why they are so different.

@balzack
Copy link
Owner

balzack commented May 13, 2024

I guess it would actually have to be (1.6) if that solution seems appropriate.

@licaon-kter
Copy link

Could I increment the minor number to resolve this? (1.2)

it's not about versionName, that can be anything even foobar

With android I use the version code as a build number, which is why they are so different.

Android cares about versionCode and so is F-Droid

@licaon-kter
Copy link

updated recipe but disabled autoupdates for now, until we can pickup the right version

https://gitlab.com/fdroid/fdroiddata/-/commit/92e7116da4798ade518ee0b2d49a0d272462007b

@balzack
Copy link
Owner

balzack commented May 15, 2024

I am happy to bump the version code way higher to match android, if that is what you recommend.

For some (wrong) reason, I thought a large versionCode should be avoided, ie. "Version 1.1 (1081004)"

Thanks again for your support, I'm sorry for the trouble.

@balzack
Copy link
Owner

balzack commented May 15, 2024

I see the pipeline build failed, but it seems related to downloading the ndk, and the build works locally. Please let me know if there is something for me to resolve.

@licaon-kter
Copy link

no, https://gitlab.com/fdroid/fdroiddata/-/jobs/6844374274/artifacts/browse/tmp/ means 3 arches were built, it's just the CI having it's storage filled :)

@balzack
Copy link
Owner

balzack commented May 26, 2024

The versionCode has been updated to 1019 in the next release to resolve my previous error. Can auto-updates be re-enabled?

@licaon-kter
Copy link

Ok, so thee new versionCodes will be 1019001..1019004, yes?

@balzack
Copy link
Owner

balzack commented May 27, 2024

yes, I think that is correct. The value in the build.gradle files is 1019, which will produce 1019001..1019004.
thank you!

@balzack
Copy link
Owner

balzack commented May 27, 2024

thanks for your support...you are awesome!

@licaon-kter
Copy link

/close this

@balzack balzack closed this as completed May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants