Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next major version changes #68

Open
4 tasks
pipex opened this issue May 9, 2024 · 0 comments · May be fixed by #70
Open
4 tasks

Next major version changes #68

pipex opened this issue May 9, 2024 · 0 comments · May be fixed by #70

Comments

@pipex
Copy link
Collaborator

pipex commented May 9, 2024

Annotating here some breaking changes to do in a single major version bump

  • Agent trace logger should not be passed to the planner, planner logs are useless for debugging, more useful is know events of planning and running a plan, and what the state changes are in between, that information can also be used for debugging in a separate environment.
  • Agent and sensor observables return a full copy of the state, however this requires a structuredClone of the state to avoid clients modifying the internal state of the agent, but moreover, the results on the agent observable can be very messy, as two sensors may report at almost exactly at the same time, resulting in the cloned object flipping values. TODO: link example later
    • Instead the agent observable should return changes as they happen in the form of operations (op, path,value). Users may act on the changes, we can export a utility to patch a state object using the path.
    • This will be good for testing as well, as the list of changes should equal the final state reported by the agent.
  • not really breaking, but it would be good to interrupt planning if it takes over some length of time, we already have maxSearchDepth, but preventing the agent from getting stuck in the planning stage seems worth it
  • Improve agent logging, perhaps using open telemetry
@pipex pipex linked a pull request May 27, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant