Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drivelist fails to compile on Mac #391

Open
sebastianrath opened this issue Apr 30, 2021 · 3 comments
Open

drivelist fails to compile on Mac #391

sebastianrath opened this issue Apr 30, 2021 · 3 comments

Comments

@sebastianrath
Copy link

sebastianrath commented Apr 30, 2021

There is already an open issue about failed compilations on Mac in #390 but this one below is different, and I am still trying to wrap my head around it.

I use Electron 12.0.5 with Node 14.16.1 and node-gyp v8.0.0 with the latest version of drivelist. The compilation succeeds, but the post builds fail when drivelist.o.d.raw is deleted.

$ npm install electron:build
...
cannot execute  cause=exit status 1

    > drivelist@9.2.4 install /Users/sebastian/Documents/snowfs/node_modules/drivelist
    > prebuild-install || node-gyp rebuild
    
      CXX(target) Release/obj.target/drivelist/src/drivelist.o
    make [ 'BUILDTYPE=Release', '-C', 'build' ]
    
                    errorOut=prebuild-install WARN install No prebuilt binaries found (target=12.0.5 runtime=electron arch=x64 libc= platform=darwin)
    rm: ./Release/.deps/Release/obj.target/drivelist/src/drivelist.o.d.raw: No such file or directory

AFAICS the error appears during the auto-generated makefile:

# Helper that executes all postbuilds until one fails.
define do_postbuilds
  @E=0;\
  for p in $(POSTBUILDS); do\
    eval $$p;\
    E=$$?;\
    if [ $$E -ne 0 ]; then\
      break;\
    fi;\
  done;\
  if [ $$E -ne 0 ]; then\
    rm -rf "$@";\             <!------------------------
    exit $$E;\
  fi
endef

Does anyone have further insights, what is happening here?

@jfo8000
Copy link

jfo8000 commented Nov 29, 2021

I had to set to "drivelist": "6.4.3" - not sure if this is the correct solution or not, am a little confused.

@thundron
Copy link
Contributor

@seb-mtl have you tried with node 12 instead? I'm trying to lure out some issues with node 14 and node 16, maybe this is one of them too

@jfo8000
Copy link

jfo8000 commented Feb 2, 2022

Yeah I swapped to node 14 and seems to be sort of working. I think my main issue now is the API seems to have changed between the two versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants