Skip to content
This repository has been archived by the owner on Oct 26, 2021. It is now read-only.

Start storing currency codes alongside a bool marking it as crypto or fiat to avoid conflicts #540

Open
einsteinx2 opened this issue Jan 31, 2018 · 0 comments

Comments

@einsteinx2
Copy link
Contributor

Right now we don't specify that a currency is crypto or fiat, we just assume if it doesn't match a fiat code then it's crypto. However there are at least two fiat currencies that match crypto symbols (Solomon Islands Dollar [SBD] and Saint Helena Pound [SHP]). In these cases, the currencies are obscure and can just be removed from our enum, but it would be best to specifically mark currencies (both in the exchanges rates data as well as local app data) as crypto or fiat. Then we can enable all fiat currencies and not worry about conflicts. For now this is fine as the conflicts are only with currencies unlikely to be used by our users, but in the future as there are more and more crypto symbols this will be the best solution I think.

@einsteinx2 einsteinx2 added this to the Release 1.1 milestone Jan 31, 2018
einsteinx2 added a commit that referenced this issue Jan 31, 2018
Mainly removed small island nations that are least likely to be used. I commented them out rather than deleting as we’ll re-enable them when we complete issue #540.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant