Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SchemaRenderer 里对 activeKey 和 defaultActiveKey 的特殊处理是否可以移除 #10182

Closed
UltramanTix opened this issue May 8, 2024 · 2 comments
Closed

SchemaRenderer 里对 activeKey 和 defaultActiveKey 的特殊处理是否可以移除 #10182

UltramanTix opened this issue May 8, 2024 · 2 comments
Assignees
@2betop
Labels
enhancement New feature or request

Comments

@UltramanTix
Copy link

UltramanTix commented May 8, 2024 •
edited

是否关联于某个问题吗：

SchemaRenderer 里面将 activeKey 和 defaultActiveKey 做了转换，导致自定义组件只要用到这两个 key 都可能导致异常，实际上amis-core 核心库没有任何逻辑跟这两个字段相关，只是在 amis-ui 有部分组件有这两个字段，amis-ui的逻辑不应该放在 amis-core 里面做兼容。
image

预期的解决方案：

删除amis-core 里面对这两字段的特殊处理
@UltramanTix UltramanTix added the enhancement New feature or request label May 8, 2024
@UltramanTix UltramanTix changed the title default SchemaRenderer 里对 activeKey 和 defaultActiveKey 的特殊处理是否可以移除 May 8, 2024
@2betop 2betop self-assigned this May 8, 2024
@2betop
Copy link
Collaborator

2betop commented May 11, 2024

schema 里面不应该存在受控属性，把 value 装成 defaultValue 把 activeKey 转成 defaultActiveKey 看起来都正常啊

@2betop
Copy link
Collaborator

2betop commented May 20, 2024

目前看来不需要移除，有问题可 reOpen 讨论

@2betop 2betop closed this as completed May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@2betop 2betop

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@2betop @UltramanTix