Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for local dependencies #111

Open
montogeek opened this issue Jul 19, 2017 · 3 comments
Open

Support for local dependencies #111

montogeek opened this issue Jul 19, 2017 · 3 comments

Comments

@montogeek
Copy link

Hi!
I just come to a project that uses local dependencies: "e2-scripts-utils": "file:../../lib/utils", when running next-update, it fails with the following error:

Problem checking NPM dependency e2-scripts-utils version file:../../lib/utils
Invalid comparator: file:../../lib/utils

Looks like it does not support local dependencies, is there a way to ignore them or something?

Thanks!

@bahmutov
Copy link
Owner

Hmm, it should probably skip file:... dependencies.

bahmutov added a commit that referenced this issue Jul 19, 2017
@bahmutov
Copy link
Owner

Can you provide more details? I tested this in test/test-file-deps against latest version and it seems to skip these by default

@montogeek
Copy link
Author

The project works, but next-update tries to install it again (run npm i), at some point it returns this error:

cannot find file /Users/montogeek/project/node_modules/e2-scripts-utils/package.json
ERROR: cannot find module e2-scripts-utils
ERROR testing next working updates
Error: Current installation is incomplete. Please run `npm install` or `bower install` first
    at /Users/montogeek/.nvm/versions/node/v7.7.4/lib/node_modules/next-update/src/next-update.js:51:20
    at _combinedTickCallback (internal/process/next_tick.js:73:7)
    at process._tickCallback (internal/process/next_tick.js:104:9)
From previous event:
    at checkCurrentInstall (/Users/montogeek/.nvm/versions/node/v7.7.4/lib/node_modules/next-update/src/next-update.js:69:10)
    at Object.<anonymous> (/Users/montogeek/.nvm/versions/node/v7.7.4/lib/node_modules/next-update/bin/next-update.js:91:3)
    at run (bootstrap_node.js:427:7)
    at startup (bootstrap_node.js:148:9)
    at bootstrap_node.js:542:3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants