Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Add new style for social: ?style=social #91

Open
chrimaho opened this issue Jan 3, 2023 · 6 comments
Open

Feature Request: Add new style for social: ?style=social #91

chrimaho opened this issue Jan 3, 2023 · 6 comments

Comments

@chrimaho
Copy link

chrimaho commented Jan 3, 2023

Feature Request

Q A
New Feature yes
RFC yes
BC Break unknown

Summary

You currently have these styles, and they are very useful:

style demo
flat
flat-square
plastic
for-the-badge

However, shields.io has one other style available: social. See more info here.

For example:

style demo
flat
flat-square
plastic
for-the-badge
social

But when I try to use this for Profile Views:
![](https://komarev.com/ghpvc/?username=chrimaho&style=social)

Can you please also add this ?style=social function to your repo?

Also related to this issue on another repo.

Thank you!

@JellyBellyDev
Copy link
Collaborator

JellyBellyDev commented Jan 3, 2023

Hi @chrimaho
you suggest to add a simple social badge without octocat or with octocat?
I'm asking this because this library is agnostic to external context such as the github logo. It is meant to be fully configurable on content and colors, adding the github logo by default would imply a coupling.
Do not you think?

@antonkomarev
Copy link
Collaborator

antonkomarev commented Jan 3, 2023

@chrimaho I recommend you to remove the rendered counter from the message. Otherwise your profile view increments on thread open and on each page refresh ))

@chrimaho
Copy link
Author

chrimaho commented Jan 3, 2023

@JellyBellyDev
Copy link
Collaborator

I understand, @chrimaho do you want to try to make a PR?

@chrimaho
Copy link
Author

chrimaho commented Jan 3, 2023

@JellyBellyDev , I would like to, but I'm afraid I don't know which part of your repo would need to be changed to facilitate this new feature. I'm not very experienced in the php language.

@JellyBellyDev
Copy link
Collaborator

@chrimaho ok, no problem! I'll try it as soon as I have some time! ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants