Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kind and type form fields have wrong width for large screens #22980

Open
2 tasks done
shubhangr opened this issue Feb 15, 2024 · 18 comments
Open
2 tasks done

Kind and type form fields have wrong width for large screens #22980

shubhangr opened this issue Feb 15, 2024 · 18 comments
Assignees
Labels
bug Something isn't working frontend good first issue Good for newcomers help wanted Help/Contributions wanted from community members

Comments

@shubhangr
Copy link

📜 Description

In the following Backstage demo, the fields Kind and Type have shorter width compared to the rest for large screens. Can anyone confirm if its intended or if its a bug?

👍 Expected behavior

Either width of all fields expand to fill the space OR the width should be limited like type and kind

👎 Actual Behavior with Screenshots

Inconsistent behaviour for large screens
Screenshot 2024-02-15 at 13 13 35

👟 Reproduction steps

Steps to reproduce:

📃 Provide the context for the Bug.

No response

🖥️ Your Environment

No response

👀 Have you spent some time to check if this bug has been raised before?

  • I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

Are you willing to submit PR?

None

@shubhangr shubhangr added the bug Something isn't working label Feb 15, 2024
@camilaibs camilaibs added good first issue Good for newcomers help wanted Help/Contributions wanted from community members labels Feb 19, 2024
@dawitamene
Copy link
Contributor

@camilaibs @tudi2d Hello, I've contributed before and I'm interested in working on this one. Could you assign it to me?

@tudi2d
Copy link
Member

tudi2d commented Feb 22, 2024

Sure @dawitamene - feel free to go ahead with this!

@MdSadiqMd
Copy link

@camilaibs @tudi2d Hey, I'm Interested too to work on it can i go ahead with it

@waliamaheep
Copy link

@camilaibs @tudi2d - I want to work on this.

@awanlin
Copy link
Collaborator

awanlin commented Mar 4, 2024

Hi @MdSadiqMd and @waliamaheep, it was assigned to @dawitamene and they have a PR open for it. Appreciate your willing ness to help, feel free to check out the other issues as I'm sure there are other opportunities to help out! 🚀

@awanlin
Copy link
Collaborator

awanlin commented Mar 4, 2024

@tudi2d there seems to be a bit of conflict. @dawitamene was assigned but it looks like we started to review the PR from @MdSadiqMd.

#23243
#23236

@MdSadiqMd
Copy link

@awanlin I haven't made any PR for this issue confirm it once again
By the way thanks for the clarity let me go through other issues

@awanlin
Copy link
Collaborator

awanlin commented Mar 4, 2024

Sorry, @MdSadiqMd, you are right. Looks like @waliamaheep was the other to create a PR

@tudi2d
Copy link
Member

tudi2d commented Mar 5, 2024

oh sorry... that's not a cool move - I did not recognize that, sorry. Closed the first PR as a duplicate, eventhough the idea was right (but also needed fixes & went stale once already). Let's get @dawitamene's PR into a good state & merge it in.

Copy link
Contributor

github-actions bot commented May 4, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label May 4, 2024
@awanlin
Copy link
Collaborator

awanlin commented May 4, 2024

In the end neither of the PRs opened for this got merged, would be great to see this fixed though, feel like a great first issue for someone!

@github-actions github-actions bot removed the stale label May 4, 2024
@MdSadiqMd
Copy link

I'm Interested in taking up this issue
@awanlin would you please assign me this

@awanlin awanlin assigned MdSadiqMd and unassigned dawitamene May 5, 2024
@awanlin
Copy link
Collaborator

awanlin commented May 5, 2024

Sure @MdSadiqMd, I've assigned it to you 👍

FYI @dawitamene just wanted to loop you in, your PR went stale and was closed

@MdSadiqMd
Copy link

please do only check this pull request other had some bug(I don't know why they occurred) that other commits of other users had also involved in my pull request
and @awanlin a DCO check had failed in PR could you guide me to solve it or assign someone who can help me with it

@VamshiReddy02
Copy link

Hey @MdSadiqMd, thank you for your contribution. I have a question for you: Did you read the CONTRIBUTING.md guide before raising the PR? Also, the reason other commits from different users are involved in your pull request is because you didn't create a separate git branch before making changes.

@MdSadiqMd
Copy link

Oh I am sorry about that can I Just make another PR

@moradebianchetti81
Copy link

hi, if this problem cannot be solved I would like to take it

@vinzscam
Copy link
Member

hi, if this problem cannot be solved I would like to take it

no need to ask, first green PR with proper changesets and DCO wins this issue 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend good first issue Good for newcomers help wanted Help/Contributions wanted from community members
Projects
None yet
10 participants