Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'closed' versions or releases should be excluded from droppables #1158

Open
fuminori-ido-m opened this issue Aug 8, 2022 · 0 comments
Open

Comments

@fuminori-ido-m
Copy link

In lib/backlogs_project_patch.rb, ProjectPatch::InstanceMethods#_sql_for_droppables gather infos of [projects.id, versions/releases ids under the projects], which will be used to check a story can be dragged&dropped on the page.

When the number of versions and/or releases become large, two problems arise:

A) the SQL takes long time (e.g. 26 seconds under Versions.count ~= 900 and projects.count ~= 240 our case).
B) In MySQL, GROUP_CONCAT default max length is 1024 chars so that the _sql_for_droppables method easily exeeds at our case; the result is chopped so that incorrect value is returned.

Solution for A

I think the closed versions and releases should be excluded from droppables because they are not used at backlog page, am I right?

Our team has already proceeded the PR at our forked repository (because drag&drop doesn't work anyway since project-tree issue(see #1157 )), but I would like to confirm here that my understanding and solution for A is right or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant