-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contrib Group Application: shashankthigale11 + oauth_client #780
Comments
Hi @shashankthigale11, I'm sorry for the delay. I'll try to get some eyes on this application. |
Hey @shashankthigale11 👋🏼 ...apologies for the delay here, but the community has been busy with the upcoming minor core release. I'm having a look at your application now 👀 |
Confirming that the namespace https://www.drupal.org/project/oauth_client does not exist 👍🏼 (only https://www.drupal.org/project/oauth2_client and https://www.drupal.org/project/openid_connect which has "OAuth client" in the project human-readable name, but no namespace clash). No clash in Backdrop contrib either 👍🏼 @shashankthigale11 can you please update this line in the README?:
Since the module has not been ported over from Drupal, that line should be better as "Created for Backdrop by ...". Both a README.md and an appropriate LICENSE.txt are included in the project, so we're all good there 👍🏼 Before we can make a final review and approve your application, I was wondering if you can please take the time to address the following things:
Apologies for the lengthy list of items I am requesting above - I hope that it doesn't deter you from contributing. Let me know when you have addressed the above issues, and I will have another look then ...or if you have any questions or need help with any of the above items in the meantime, then also let us know and we can assist you. Thank you for contributing to Backdrop! 🙏🏼 |
@shashankthigale11 I also wanted to say that you can consider joining us in our official Zulip chat to get answers to any questions faster (you can use your GitHub account to join). You are free to join any existing thread, or start a new one, but this is where we are handling notifications about contrib applications: https://backdrop.zulipchat.com/#narrow/stream/218635-Backdrop/topic/Contrib.20Application If you have any question, or you think we are taking too long to reply here, then please drop a message there, and our friendly community members will be happy to assist you :) |
I recommend using a namespace that makes it more explicit that this is for only Azure and related. Currently oauth_client makes it seem like it's much more generic. |
@shashankthigale11 It looks like you've gotten a lot of feedback, but all of that is intended to be helpful - none of it is a requirement to join Backdrop Contrib. Since it appears that you have met the only 2 actual requirements...
An invitation to join the Backdrop Contrib group is on the way! 🎉 Please check your inbox and accept the invitation :) Once you have accepted the invitation, feel free to transfer the repository into the backdrop-contrib group at any time (ask here if you have questions). |
Hello and welcome to the contrib application process! We're happy to have you :)
Please indicate how you intend to help the Backdrop community by joining this group
Based on your selection above, please provide the following information:
Option 1: I would like to contribute a project.
Name of the module: OAuth Client
This module is not ported from Drupal 7 and its a completely new module.
(option 1) Please note these 3 requirements for new contrib projects:
You can use this example: https://raw.githubusercontent.com/backdrop-ops/contrib/master/examples/README.md
You can use this example: https://raw.githubusercontent.com/backdrop-ops/contrib/master/examples/LICENSE.txt.
If porting a Drupal 7 project, Maintain the Git history from Drupal.Post a link to your new Backdrop project under your own GitHub account (option 1)
https://github.com/shashankthigale11/oauth_client
If you have chosen option 2 or 1 above, do you agree to the Backdrop Contributed Project Agreement
YES
The text was updated successfully, but these errors were encountered: