Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Value of "Backup Source" isn't saved with "Advanced Backup" profile settings #145

Open
indigoxela opened this issue Dec 16, 2023 · 3 comments

Comments

@indigoxela
Copy link
Member

indigoxela commented Dec 16, 2023

Not sure if this is intended, but it feels a bit odd:

On admin/config/system/backup_migrate/export/advanced one can create custom profiles. All values except for "Backup Source" are saved, so every time one runs a backup, one has to remember, which source this setting is meant for.

This might be by intention or an oversight. But given, that Backdrop has more possible sources than D7, it seems worth considering.

It's not urgent, BTW.

@indigoxela indigoxela changed the title Value of "Backup Source" isn't saved with "Advanced Backup" settings Value of "Backup Source" isn't saved with "Advanced Backup" profile settings Dec 16, 2023
@argiepiano
Copy link
Collaborator

argiepiano commented Dec 16, 2023

I believe that's on purpose (although I don't think it's very sensible). The UI gives us a clue that you can use any profile to create backups for any source:
Screen Shot 2023-12-16 at 7 22 56 AM

The one thing that DOES get saved is the list of excluded files for all available sources. Those are saved within the profile db record.

If you ask me, I think the architecture (and code) of BM is pretty screwy. It looks like things were added over the years without much refactoring or thinking.

Anyway, BM is used so much that perhaps we'll need to wait until a new major release to refactor.

@izmeez
Copy link

izmeez commented Feb 4, 2024

Also sources are saved in the scheduled backups.

@izmeez
Copy link

izmeez commented Feb 4, 2024

It maybe okay the way it is for manual backups because it saves the last used and gives flexibility to user to select what they want for the manual backup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants