Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix markerinfo handling #695

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Fix markerinfo handling #695

wants to merge 3 commits into from

Conversation

dominikbach
Copy link
Contributor

@dominikbach dominikbach commented Apr 20, 2024

Fixes #670 and fixes #672 .

Changes proposed in this pull request:

  1. bug in pspm_get_markerinfo #670 was caused by a faulty markerinfo structure in a file that had been preprocessed multiple times. It is unclear what caused this faulty structure; it did not appear when the file was re-imported. Added a check for the markerinfo structure in pspm_check_data to catch such cases.
  2. A potential root cause for (1) is the function pspm_combine_markerchannels which creates a char rather than cell array for markerinfo.name. This was fixed.
  3. problem running GLM with conditions created from markerinfo #672 was caused in pspm_get_timing, called by pspm_check_model. This check will fail because at this point, the data (and therefore, the markerinfo structure) has not yet been loaded. pspm_check_model is now adapted.
  4. A bug in pspm_cfg_run_glm was removed.
  5. Option to work on multiple data files for pspm_combine_markerchannels was removed, in line with Unify function output #689.

@dominikbach dominikbach self-assigned this Apr 20, 2024
@dominikbach dominikbach added the In Progress Currently being worked on label Apr 20, 2024
@dominikbach dominikbach added Completed & Waiting for Review Completed and waiting for review and removed In Progress Currently being worked on labels May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Completed & Waiting for Review Completed and waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

problem running GLM with conditions created from markerinfo bug in pspm_get_markerinfo
1 participant