Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New function which directly imports acq file data #659

Draft
wants to merge 12 commits into
base: develop
Choose a base branch
from
Draft

New function which directly imports acq file data #659

wants to merge 12 commits into from

Conversation

MadniAbdulWahab
Copy link
Contributor

@MadniAbdulWahab MadniAbdulWahab commented Mar 14, 2024 •
edited

Fixes # 646.

Changes proposed in this pull request:

  • New function which reads and load data directly from acq file using python tool Bioread.

@MadniAbdulWahab MadniAbdulWahab added the Completed & Waiting for Review Completed and waiting for review label Mar 14, 2024
@MadniAbdulWahab MadniAbdulWahab linked an issue Mar 14, 2024 that may be closed by this pull request
Direct import of newer acq data #646
Open
@dominikbach
Copy link
Contributor

@teddychao Could you please add the necessary environment (pspm_init, documentation, GUI) and make the function name compatible with existing standards.

@dominikbach dominikbach self-requested a review March 15, 2024 13:25
@dominikbach dominikbach added In Progress Currently being worked on and removed Completed & Waiting for Review Completed and waiting for review labels Mar 18, 2024
@teddychao teddychao marked this pull request as draft April 19, 2024 00:47
@teddychao
Copy link
Contributor

Hi @MadniAbdulWahab
I have updated the GUI and python environment settings. I tested this on my computer and I am not sure if the issues I saw were caused by Python packages. Can you have a look and let me know if data can be imported on your computer. Thanks.
image

Best wishes
Teddy

@teddychao teddychao added Requesting Manual Tests The pull request needs manual tests by collaborators and removed In Progress Currently being worked on labels May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dominikbach dominikbach Awaiting requested review from dominikbach

At least 1 approving review is required to merge this pull request.

Assignees

@teddychao teddychao

@MadniAbdulWahab MadniAbdulWahab

Labels
Requesting Manual Tests The pull request needs manual tests by collaborators
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Direct import of newer acq data
3 participants
@MadniAbdulWahab @dominikbach @teddychao