Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve pspm_write_channel #624

Closed
dominikbach opened this issue Feb 10, 2024 · 0 comments · Fixed by #689
Closed

Improve pspm_write_channel #624

dominikbach opened this issue Feb 10, 2024 · 0 comments · Fixed by #689
Labels
Non-Conceptional The pull request does not include conceptional updates

Comments

@dominikbach
Copy link
Contributor

dominikbach commented Feb 10, 2024

Feature Description

Currently, pspm_write_channel, overwrites the last channel of same type if channel_action is 'replace'. However, when channels are defined by numerical index in the calling function, it would be more appropriate to overwrite the input channel.

Steps to solve this

  1. Identify all functions that use pspm_write_channel, allow channel_actionto be replace, and do not create channels of new type.
  2. Check whether these functions pass correct channel numbers to pspm_write_channels. Channel numbers should correspond to those that were retrieved from the file with a pspm_load_channel function call, or otherwise within the calling function.
  3. Compile a list of functions that fulfill 1 and not 2.
  4. Implement correct assignment of channel numbers in these functions.
@teddychao teddychao added the Non-Conceptional The pull request does not include conceptional updates label Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Non-Conceptional The pull request does not include conceptional updates
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants