Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MovementX and MovementY to relevant MouseEventArgs #838

Open
linkdotnet opened this issue Aug 17, 2022 · 2 comments
Open

Add MovementX and MovementY to relevant MouseEventArgs #838

linkdotnet opened this issue Aug 17, 2022 · 2 comments
Labels
good first issue Good for newcomers

Comments

@linkdotnet
Copy link
Sponsor Collaborator

.net7.0-preview7 introduced two new properties on the MouseEventArgs: MovementX and MovementY (API diff, current main).

I tried to find in which places the property gets set, but found only a view occurrences (and not even the obvious MouseMoveEvent):
image

The most obvious case would be to add it to mousemove. Not sure where you need it on onclick.
For starters we could go with that and see if folks need it somewhere else.

@linkdotnet linkdotnet added the input needed When an issue requires input or suggestions label Aug 17, 2022
@egil
Copy link
Member

egil commented Aug 17, 2022

If we add it to one of the handler trigger methods with all the default arguments, then we should for consistency sake add it to all.

For now, it's a nice to have. Users that want to set these can use the handler trigger method that takes an MouseEventArg as input.

@linkdotnet linkdotnet added good first issue Good for newcomers and removed input needed When an issue requires input or suggestions labels Aug 17, 2022
@linkdotnet
Copy link
Sponsor Collaborator Author

Labelled it as „good first issue“.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants