You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is the feature request related to a problem? Please elaborate.
The SetupModule extension for setting up an imported JS module only supports IJSObjectReference but you can also import modules of types IJSInProcessObjectReference and IJSUnmarshalledObjectReference.
The suggested solution
IJSInProcessObjectReference and IJSUnmarshalledObjectReference are derived from IJSObjectReference so I think it should be possible to support this with minor changes.
Describe any alternative solutions
If we can not use that they are derived interfaces to IJSObjectReference then it could just be implemented like the module setup feature for IJSObjectReference.
Additional context
I don't think a lot of people use this way of importing modules so might not be a priority.
The problem is that you cannot overload based on generic types, so it would mean making SetupModule generic, e.g.: SetupModule<TObjectReference>(...) where TObjectReference : IJSObjectReference to keep using the same name (SetupModule). But that will require users to always specify the IJSObjectReference or a derived type, even in the most common case, e.g. SetupModule<IJSObjectReference>(...).
As you say, its probably not too many that needs this, so I would like to keep things simple for the majority. If your workaround works, then I think I will keep it as is, and instead document this particular use case.
Is the feature request related to a problem? Please elaborate.
The
SetupModule
extension for setting up an imported JS module only supportsIJSObjectReference
but you can also import modules of typesIJSInProcessObjectReference
andIJSUnmarshalledObjectReference
.The suggested solution
IJSInProcessObjectReference
andIJSUnmarshalledObjectReference
are derived fromIJSObjectReference
so I think it should be possible to support this with minor changes.Describe any alternative solutions
If we can not use that they are derived interfaces to
IJSObjectReference
then it could just be implemented like the module setup feature forIJSObjectReference
.Additional context
I don't think a lot of people use this way of importing modules so might not be a priority.
Currently, I just do the following instead:
Might also be related to the last bit in this old issue #233 where we quickly mentioned
IJSInProcessObjectReference
The text was updated successfully, but these errors were encountered: