Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot scroll in MODX 2.3 #27

Open
bradbertz opened this issue Oct 2, 2014 · 6 comments
Open

Cannot scroll in MODX 2.3 #27

bradbertz opened this issue Oct 2, 2014 · 6 comments

Comments

@bradbertz
Copy link

When viewing formsave form submission list, I cannot scroll down the list.

@yuka123
Copy link

yuka123 commented Oct 13, 2014

I fixed this issue and created a Pull Request #28 with a fix.

The solution is a CSS solution, since the main class doesent get added by baseCls.and therefor no height is beeing set on the panel.

There is also another solution to limit results to 10 per page. (requires changing pageSize: 10 and inside processor the limit to 10). My solution adds a scrollbar just like it was before.

@digitalbricks
Copy link

+1 for the fix from @yuka123

@shaunmorrison
Copy link

Just noticed this myself. The fix isn't quite right as you shouldn't need a letterbox scroll like that (although thank for that @yuka123). I think the issue is further up the markup. When looking at something like Package Manager I see there is some JS calculating the height of the parent container. e.g. <div class=​"x-panel-body x-panel-body-noheader x-panel-body-noborder" id=​"ext-gen18" style=​"background-color:​ transparent;​ padding:​ 0px 1px 0px 0px;​ overflow:​ auto;​ width:​ 1132px;​ height:​ 825px;​">​

@sfreytag
Copy link

I also just found this problem. Thanks to @yuka123 for the insight and I agree with @shaunmorrison that ideally it should be fixed by doing some sizing further up the DOM. I have made a fix that does this, and also applies some Revo 2.3 styling to the export form. The fix is part of my branch, which also has 2 commits to enable a search function. The fix isn't brilliant: it needs some strings replacing with _(), and my sizing is done at runtime and doesn't hook into a resize event, so if the window changes size, the scrolling is broken again. So I won't mark my commit as 'fixes this issue' and I might do some further work on it.

Here's my pull request with this code:
#29

@eladnova
Copy link

eladnova commented Jun 3, 2015

Any update on a proper fix for FormSave and 2.3?

@JimKillock
Copy link

I think I opened a duplicate of this / other issues such as export / delete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants