Add json import #33
Add json import #33
Conversation
dylan-chong
force-pushed
the
add-json-import
branch
from
d25b7ea
to
045d2fe
Compare
|
Currently, the added/removed lines is not quite well supported, as it does not validate those. What would you recommend we do about those? |
dylan-chong
force-pushed
the
add-json-import
branch
from
693f823
to
b652ca6
Compare
|
I am very sorry, but I do not have time to review this pull request and have decided not to merge it. It is well written from what I have skimmed, and should be a much appreciated contribution. As for the added/removed lines, I improved input validation with commit d640a3b. This should make the program much less likely to crash. |
|
Awesome, have rebased (and fixed a few bugs) |
dylan-chong
force-pushed
the
add-json-import
branch
from
09e5699
to
6f0f9c3
Compare
dylan-chong
force-pushed
the
add-json-import
branch
from
6f0f9c3
to
4c5857c
Compare
|
Marking as draft as there is a few type/lint niggles to fix |
dylan-chong
force-pushed
the
add-json-import
branch
from
a21b062
to
3592e58
Compare
|
@b-inary I've finished fixing up the lint issues. No hurry to get this merged, but would appreciate the review if you ever get the time. If you need me to test any particular scenarios, I'm happy to do that and document the results |
Added JSON import/export page.
requires #31 to be merged first, as this is branched off that
fixes b-inary/wasm-postflop#17