Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object editor styling broken on optimized production build #34

Open
MadJayQ opened this issue Oct 16, 2019 · 2 comments
Open

Object editor styling broken on optimized production build #34

MadJayQ opened this issue Oct 16, 2019 · 2 comments

Comments

@MadJayQ
Copy link

MadJayQ commented Oct 16, 2019

Hello,

I've been using this library as a crux piece for a tool i've been working on.

When running in my dev electron environment everything works exactly as expected; however, upon packaging my application using react-scripts build to create a production build it seems the styling is completely broken.

firefox_DdHGaIuVMY

Here is my package.json

{
  "name": "nhmcs-tool",
  "version": "0.1.0",
  "build": {
    "files": [
      "build/**/*",
      "node_modules/**/*"
    ],
    "directories": {
      "buildResources": "assets"
    }
  },
  "homepage": "./",
  "main": "public/electron.js",
  "private": true,
  "dependencies": {
    "@material-ui/core": "^4.5.0",
    "@material-ui/icons": "^4.4.3",
    "@rescripts/cli": "0.0.12",
    "material-ui-icons": "^1.0.0-beta.36",
    "electron-is-dev": "^1.1.0",
    "node-uuid": "^1.4.8",
    "object-editor-react": "^1.0.6",
    "react": "^16.10.1",
    "react-dom": "^16.10.1",
    "react-scripts": "3.2.0",
    "aws-sdk": "^2.546.0",
    "typescript": "^3.6.4"
  },
  "scripts": {
    "start": "react-scripts start",
    "build": "react-scripts build",
    "test": "react-scripts test",
    "electron-dev": "concurrently \"npm start\" \"electron .\"",
    "postinstall": "electron-builder install-app-deps",
    "preelectron-pack": "npm build",
    "electron-pack": "npm run build -mw",
    "electron-exec-pack": "electron-packager ./build nhmcstool --platform=win32 --arch=x64",
    "dist": "electron-builder"
  },
  "eslintConfig": {
    "extends": "react-app"
  },
  "browserslist": {
    "production": [
      ">0.2%",
      "not dead",
      "not op_mini all"
    ],
    "development": [
      "last 1 chrome version",
      "last 1 firefox version",
      "last 1 safari version"
    ]
  },
  "devDependencies": {
    "concurrently": "^5.0.0",
    "electron": "^6.0.11",
    "rescripts": "0.0.1-security",
    "electron-builder": "^21.2.0",
    "electron-packager": "^14.0.6"
  }
}
@b-gran
Copy link
Owner

b-gran commented Oct 16, 2019

Hi @MadJayQ, is your project publicly available?
If your project is publicly available, I'll try to repro directly - otherwise let's put together a minimal repro of this issue.

@b-gran
Copy link
Owner

b-gran commented Oct 26, 2019

Hi @MadJayQ

I'm unable to repro this on the latest version, 1.1.0. Try downloading the latest version and see if there's still an issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants