Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Engineer's Explosive Extravaganza (Midsummer Fireworks Spectacular) event is unimplemented. #16677

Closed
heyitsbench opened this issue Jul 5, 2023 · 2 comments · Fixed by #18860

Comments

@heyitsbench
Copy link
Contributor

heyitsbench commented Jul 5, 2023

Current Behaviour

Currently there is some debris in front of the Exodar's entrance as a part of the Midsummer event.

Expected Blizzlike Behaviour

Timing is weird of course, but around the 4th of July (May have been a different date or nonexistent for non-US realms) a bunch of NPCs/gameobjects should spawn around various capitals. Many reveler NPCs, fireworks vendors, tables, kegs, goblets, and mugs. The NPCs should say various things depending on which area they're attending (and depending on the status of the fireworks show), and the goblets (I believe) should only be spawned for a bit, also dependent on the fireworks show. Every hour from the start of the event (Intuition says no fireworks at the start, every hour following including the last the event should take place) there should be a fireworks show at every capital city as well as Booty Bay in a specific spot. (Gates of Org, Exodar, SW, Ironforge, Silvermoon, UC; close to the flight post in TB, just off the coast of Rut'theran Village, above one of the small paths in Shattrath's upper city, and in the middle of the bay in Booty Bay) This show should go on for about ten minutes with the revelers in the area turning towards it at certain points, and (iirc) cheering at the end.

Source

Wrath Classic, Wowhead run-downs

Steps to reproduce the problem

  1. Exist on the 4th of July.
  2. Observe AzerothCore does not celebrate the United States of America's day of independence.

Extra Notes

The Exodar debris section of this report was brought to you in part by: chromiecraft/chromiecraft#5832. fixed

I have a lot of this particular event sniffed, though very possibly not all. I was sniffing at the top of every hour at every location mentioned in the report as well as Ratchet and Dalaran, neither of which I saw any sort of fireworks display or commotion at, so I believe these two do not have anything of interest related to this event.

AC rev. hash/commit

dc071da

Operating system

Windows 10 x64

Custom changes or Modules

mod-ptr-template

@sudlud
Copy link
Member

sudlud commented Nov 20, 2023

Holidays.dbc, ID 62

  • duration 18 (hours)

HolidayNames.dbc, ID 12

Fireworks Spectacular

HolidayDescriptions.dbc, ID 11

After the sun sets, the end of Midsummer is celebrated, with an hourly firework extravaganza.

To watch the show, visit any capital city or Booty Bay.

just for future reference 👀

@heyitsbench
Copy link
Contributor Author

For the record (since loosely related), the fireworks event for New Year's (as well as any other firework event, e.g. Peon Day in Europe, Chinese New Year) is a separate event, HolidayDescriptions/HolidayNames ID 2 (Fireworks Celebration rather than Fireworks Spectacular), missing the fireworks vendors, but that seems to be about the only difference.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

3 participants