Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Scripts/Spells): Taunt Flag Targeting script uses hardcoded string. #18659

Open
heyitsbench opened this issue Apr 3, 2024 · 1 comment · May be fixed by #18757
Open

(Scripts/Spells): Taunt Flag Targeting script uses hardcoded string. #18659

heyitsbench opened this issue Apr 3, 2024 · 1 comment · May be fixed by #18757
Labels
Good first issue

Comments

@heyitsbench
Copy link
Contributor

heyitsbench commented Apr 3, 2024 •
edited

Current Behaviour

Currently, the Taunt Flag Targeting script uses a hardcoded string.

azerothcore-wotlk/src/server/scripts/Spells/spell_generic.cpp

Line 139 in e413663

snprintf(buff, sizeof(buff), "%s plants the Flag of Ownership in the corpse of %s.", caster->GetName().c_str(), target->GetName().c_str());

Expected Blizzlike Behaviour

This string should be contained in DB so it can be localized.

Source

I saw it in a dream

Steps to reproduce the problem

  1. Look at the script for the spell.
  2. Observe plain English text written in the file.

Extra Notes

No response

AC rev. hash/commit

e413663

Operating system

Windows 10 x64

Custom changes or Modules

mod-ptr-template
@heyitsbench
Copy link
Contributor Author

Uses broadcast_text ID 28008.

@xaenerys0 xaenerys0 linked a pull request Apr 15, 2024 that will close this issue
Open
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(Scripts/Spells): Hardcoded text moved to database to support loca… xaenerys0/azerothcore-wotlk
1 participant
@heyitsbench