Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sets are limited to 1000 icons #289

Open
mnadalc opened this issue Jul 28, 2023 · 5 comments
Open

Sets are limited to 1000 icons #289

mnadalc opened this issue Jul 28, 2023 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@mnadalc
Copy link

mnadalc commented Jul 28, 2023

I was browsing through the Google Material Icons set and I was looking for the icon local-offer.

I couldn't find the icon, so I've tried to search for it in the Store, and it appears in the list.
However, if I click on the icon the button Go to icon set, it navigates to Google Material Icons but the icon still does not show up inside the icons list.

Looks like the set is currently limited to 1000 icons, and does not seem to have pagination in order to navigate through more icons.

I've also noticed that on the Explore Store page, the Card of Google Material Icons, it says 8764 icons (across 4 variants), but as said, only 1000 icons can be shown at once.

Would it be possible to have a pagination in order to look for all icons inside a set when searching for them?

@aykutkardas aykutkardas self-assigned this Jul 28, 2023
@aykutkardas
Copy link
Owner

Hey @mnadalc 👋🏻

I couldn't find the icon, so I've tried to search for it in the Store, and it appears in the list.
However, if I click on the icon the button Go to icon set, it navigates to Google Material Icons but the icon still does not show up inside the icons list.

You should be able to search while in the icon set.

image

I've also noticed that on the Explore Store page, the Card of Google Material Icons, it says 8764 icons (across 4 variants), but as said, only 1000 icons can be shown at once.

There seems to be a problem with the numbers. I'll check that out, thanks for letting me know.

@aykutkardas
Copy link
Owner

I found the problem, there is indeed a restriction and it is related to APIs. I will fix this as soon as possible.

@mnadalc
Copy link
Author

mnadalc commented Jul 28, 2023

I don't know if it can be related, but if I try to save a large collection of icons (for example, the whole Google Material Icons into a custom Collection), icons are not being stored into the collection.

They will show up like they have been saved into the custom collection. But if I close the session and log in again (or close the web browser), and check the custom collection again, they disappear.

@aykutkardas
Copy link
Owner

Yep, same problem, thanks for letting me know. ⚡

@aykutkardas aykutkardas added the bug Something isn't working label Jul 28, 2023
@aykutkardas
Copy link
Owner

I haven't fixed the limit on the collection update yet. But now you can list icons without the 1000 icon limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants