Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace vim.tbl_islist() with vim.islist() after NVIM v0.10.0-dev-2560 #1245

Open
Tracked by #1259 ...
CharlesChiuGit opened this issue Apr 25, 2024 · 3 comments · May be fixed by #1260
Open
Tracked by #1259 ...

replace vim.tbl_islist() with vim.islist() after NVIM v0.10.0-dev-2560 #1245

CharlesChiuGit opened this issue Apr 25, 2024 · 3 comments · May be fixed by #1260
Labels
nvim:nightly Compatibility issues caused by nightly Neovim builds upstream Upstream (neovim/plugin) issues

Comments

@CharlesChiuGit
Copy link
Collaborator

CharlesChiuGit commented Apr 25, 2024

akinsho/bufferline.nvim@a6ad228
https://neovim.io/doc/user/news.html#news-breaking

for examples:

elseif type(dst[key]) == "table" and vim.tbl_islist(dst[key]) then
vim.list_extend(dst[key], value)
elseif type(dst[key]) == "table" and type(value) == "table" and not vim.tbl_islist(dst[key]) then

@CharlesChiuGit
Copy link
Collaborator Author

todo

@Jint-lzxy
Copy link
Collaborator

I think we could consider postponing this change until the API stabilizes - afaik this and similar APIs have undergone numerous iterations since the initial change, and the synopsis has also experienced incompatible changes (which would render it incompatible even with older nightly builds). Plus since it's only deprecated, imo it's safe to continue using it until v0.10 is released.

@Jint-lzxy Jint-lzxy added upstream Upstream (neovim/plugin) issues nvim:nightly Compatibility issues caused by nightly Neovim builds labels Apr 30, 2024
@CharlesChiuGit
Copy link
Collaborator Author

I think we could consider postponing this change until the API stabilizes

agree~

@ayamir ayamir linked a pull request May 20, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nvim:nightly Compatibility issues caused by nightly Neovim builds upstream Upstream (neovim/plugin) issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants