Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Cargo.lock #816

Open
kriomant opened this issue Oct 15, 2023 · 2 comments
Open

Missing Cargo.lock #816

kriomant opened this issue Oct 15, 2023 · 2 comments
Labels
good first issue Good for newcomers

Comments

@kriomant
Copy link
Contributor

It's not easy to set up environment for eBPF development.
Some kernels have bugs, some package version miss features, some rust versions produce invalid code. So I fixed most versions to be able to reproduce working environment.

However, when I install 'aya-tool', despite I use exact git revision, all it's dependencies are resolved afresh which often causes failure.
Last case was fresh 'anstream' dependency which stopped building with rust version I use. I want to use cargo install --locked here, but 'aye-rs' repository miss 'Cargo.lock', so it won't work.

Can you please add 'Cargo.lock'? Note that it won't change current behavior for most users, because lock file is only used when '--locked' options is given and current documentation doesn't use it.

@alessandrod
Copy link
Collaborator

Which kernels have bugs? Which package versions miss features? Which rust versions produce invalid code?

@kriomant
Copy link
Contributor Author

Sorry, it was just an explanation why I fix all the versions I can.

The real problem is that cargo install --git https://github.com/aya-rs/aya -- aya-tool installs different aya-tool binary every time it is called. I can fix version of aya-tool itself with --git and --rev. But I can't fix versions of aya-tool dependencies, because there is no corresponding Cargo.lock in the repo.

Last time I tried to reproduce my env, 'anstream' dependency was updated and it can no longer be compiled with rust version I use. And updating rust version is a pain.

@vadorovsky vadorovsky added the good first issue Good for newcomers label Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants