Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix codebase to build with Qt 5 #225

Open
jakepetroules opened this issue Apr 4, 2013 · 2 comments
Open

Fix codebase to build with Qt 5 #225

jakepetroules opened this issue Apr 4, 2013 · 2 comments
Assignees
Labels
Milestone

Comments

@jakepetroules
Copy link
Contributor

The only remaining issue is HSSObject::shared_from_this() / HSSParserNode::shared_from_this(); that QWeakPointer constructor overload is no longer available.

Also, even Google discourages use of shared pointers. https://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Smart_Pointers

@ghost ghost assigned veosotano Apr 4, 2013
@veosotano
Copy link
Member

Is the .toStrongRef() method still there or will we need to get rid of smart pointers entirely?

Sent from my iPhone

On 04/04/2013, at 02:56, Jake Petroules notifications@github.com wrote:

The biggest issue is HSSObject::shared_from_this(); that QWeakPointer constructor overload is no longer available.

Also, even Google discourages use of shared pointers. https://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Smart_Pointers


Reply to this email directly or view it on GitHub.

@jakepetroules
Copy link
Contributor Author

Of course not. The constructor in question was simply removed because it allowed the classes to be used in an incorrect manner. I'm not really sure but you can be certain it was for a good reason.

We should still lessen our usage of smart pointers though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants