Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yarn installations #86

Open
zanettin opened this issue Aug 29, 2017 · 4 comments
Open

Yarn installations #86

zanettin opened this issue Aug 29, 2017 · 4 comments

Comments

@zanettin
Copy link

Hi

When we install browser-perf via Yarn, the "cleanup modules" tasks cleans up docs folder which is required that the code works as expected. Maybe you can rename the folder to ensure correct behaviour also for Yarn users?

Thanks a lot for this great tool!
Cheers

@axemclion
Copy link
Owner

@zanettin Thanks for reporting the issue.

Are you using yarn clean and running into the issue ? Could you please help with repro steps ?

@zanettin
Copy link
Author

Hi @axemclion

Yes exactly. yarn clean does that.
Love this task and works quite great except for browser-perf on our react app 😄
What do you think?

Seams like this directories are removed:

docs
doc
website
images
assets

@axemclion
Copy link
Owner

@zanettin Do you suggest I rename docs to something else ? I could look to see if there is a way to not delete those folders.

@zanettin
Copy link
Author

zanettin commented Sep 1, 2017

yes, if this is an option for you. listed folders from above are deleted by yarn clean. if you find another workaround/option it would also be great :-) thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants