Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

s2n_tls13_cert_verify_test doesn't run all cases #4431

Open
jmayclin opened this issue Feb 20, 2024 · 1 comment · May be fixed by #4545
Open

s2n_tls13_cert_verify_test doesn't run all cases #4431

jmayclin opened this issue Feb 20, 2024 · 1 comment · May be fixed by #4545
Assignees
@jouho
Labels
priority/high Rank 2 size/small

Comments

@jmayclin
Copy link
Contributor

Problem:

A test case is gated behind a compile definition

s2n-tls/tests/unit/s2n_tls13_cert_verify_test.c

Lines 38 to 40 in 89dba0e

#if RSA_PSS_CERTS_SUPPORTED
{ .cert_file = S2N_RSA_PSS_2048_SHA256_LEAF_CERT, .key_file = S2N_RSA_PSS_2048_SHA256_LEAF_KEY, .sig_scheme = &s2n_rsa_pss_pss_sha256 },
#endif

However, the header that defines RSA_PSS_CERTS_SUPPORTED is never included, so it unconditionally evaluates to false, and the RSA-PSS test cases are never executed. Additionally, these test cases fail when the compile definition is corrected.

Previous discussion on this can be seen on the earlier comments in #4430
@maddeleine
Copy link
Contributor

May be an opportunity for try-compile here: #3327.

@jouho jouho self-assigned this Apr 25, 2024
@jouho jouho linked a pull request May 7, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jouho jouho

Labels
priority/high Rank 2 size/small
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: cert verify test fix aws/s2n-tls
4 participants
@lrstewart @jmayclin @jouho @maddeleine