Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nodeclass / ec2nodeclass not in labels #5178

Open
runningman84 opened this issue Nov 28, 2023 · 3 comments
Open

Nodeclass / ec2nodeclass not in labels #5178

runningman84 opened this issue Nov 28, 2023 · 3 comments
Assignees
@rschalo
Labels
feature New feature or request good-first-issue Good for newcomers v1.x Issues prioritized for post-1.0

Comments

@runningman84
Copy link

Description

What problem are you trying to solve?
It is difficult to find out which nodeclass is used for a given instance. Please add a human readable label to the instances

How important is this feature to you?
nice to have

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment
@runningman84 runningman84 added feature New feature or request needs-triage Issues that need to be triaged labels Nov 28, 2023
@jmdeal jmdeal removed the needs-triage Issues that need to be triaged label Nov 28, 2023
@jonathan-innis jonathan-innis added the v1 Issues requiring resolution by the v1 milestone label Nov 29, 2023
@jmdeal
Copy link
Contributor

jmdeal commented Dec 4, 2023

This seems like a reasonable default, I'm not sure if we'd be able to get this in for the next release but for the time being you can specify the label via the NodePool.

...
spec:
  template:
    metadata:
      labels:
        ec2nodeclass: <ec2nodeclass-name>
...

@billrayburn billrayburn added the good-first-issue Good for newcomers label Dec 6, 2023
@jonathan-innis
Copy link
Contributor

I'd imagine that this the label would match the current tag that's assigned to instances karpenter.k8s.aws/ec2nodeclass

@jonathan-innis jonathan-innis mentioned this issue Dec 9, 2023
Open
@pradeepnnv
Copy link

I would like to work on this issue.

@billrayburn billrayburn added v1.x Issues prioritized for post-1.0 and removed v1 Issues requiring resolution by the v1 milestone labels Jan 23, 2024
@rschalo rschalo mentioned this issue May 1, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rschalo rschalo

Labels
feature New feature or request good-first-issue Good for newcomers v1.x Issues prioritized for post-1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: add nodeclass name as label to nodeclaim rschalo/karpenter-provider-aws
6 participants
@runningman84 @billrayburn @pradeepnnv @jmdeal @jonathan-innis @rschalo