Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce Duplication between ACMachineTest and MachineTest #83

Open
baldawar opened this issue Mar 31, 2023 · 0 comments
Open

Reduce Duplication between ACMachineTest and MachineTest #83

baldawar opened this issue Mar 31, 2023 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@baldawar
Copy link
Collaborator

Tracking ticket to follow up on #82 (comment)

What I have been doing recently is added rulesForJSONEvent tests to ACMachineTest and adding rulesForEvent tests (otherwise identical) to MachineTest. I think that is the intended difference between the two test classes? So change this and add a version to ACMachineTest? Of course, we should probably think through a path forward to stop duplicating all tests.

Need to

  • combine tests cases (some are missing from ACMachineTest and others are lacking in MachineTest)
  • build a wrapper method to call both rulesForJSONEvent and rulesForEvent
  • handle cases when both should be returning different results for Array Consistency.
@baldawar baldawar added bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed labels Mar 31, 2023
@baldawar baldawar mentioned this issue Mar 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@baldawar