Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for wildcard/ignore-case #74

Open
schenksj opened this issue Feb 16, 2023 · 1 comment
Open

Support for wildcard/ignore-case #74

schenksj opened this issue Feb 16, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@schenksj
Copy link
Contributor

schenksj commented Feb 16, 2023

What is your idea?

It would be awesome to have a case-insensitive wildcard. Curious of the communities thoughts. On the surface, it doesn't seem like a tough implementation, though I'm not terribly confident in the syntax given that we were trying to avoid an ignore-case keyword...

{
  "detail": {
    "command_path": [  {"wildcard":  {"ignore-case": "*/Cmd.exe*"}  } ]
  }
}

The above matches stufff/cmd.exe -x stuff/Cmd.exe -x StUff/CmD.ExE .

Would you be willing to make the change?

Probably

Additional context

Add any other context (such as images, docs, posts) about the idea here.

@schenksj schenksj added the enhancement New feature or request label Feb 16, 2023
@baldawar
Copy link
Collaborator

we can change ignore-case to ignore-case-equals for the sake of consistency, but I have the similar performance concerns as mentioned in #72. I worry that this'll be diminishing returns.

For your use-case, are there any constraints on performance / match-time / rule compile time ? If so, we'd have to consider the effort tied to it (esp if you expect many wildcards to be use for a single key).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants