Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add standard for taking a new dependency #57

Open
baldawar opened this issue Nov 14, 2022 · 0 comments
Open

Add standard for taking a new dependency #57

baldawar opened this issue Nov 14, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@baldawar
Copy link
Collaborator

What is your idea?

Follow up from #55 (comment)

Do we have a standard about adopting dependencies? I remember doing quite a bit of work inside AWS to convince myself/others that a dependency was acceptable.
...
We don't have a standard today

We can use this issue to aggregate opinions and prior art from similar libraries.

Would you be willing to make the change?

No

Additional context

We can update https://github.com/aws/event-ruler/blob/main/CONTRIBUTING.md with some standard guidance on when it is okay to take a new dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant