Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecations messages in symfony 5.4 #2665

Open
Spawnrad opened this issue Mar 27, 2023 · 1 comment
Open

Deprecations messages in symfony 5.4 #2665

Spawnrad opened this issue Mar 27, 2023 · 1 comment
Assignees
Labels
bug This issue is a bug. investigating This issue is being investigated and/or work is in progress to resolve the issue. p2 This is a standard priority issue

Comments

@Spawnrad
Copy link

Describe the bug

Lot of deprecation messages when using this SDK with Symfony 5.4

Expected Behavior

No deprecation message

Current Behavior

User Deprecated: Method "Iterator::key()" might add "mixed" as a native return type declaration in the future. Do the same in implementation "Aws\ResultPaginator" now to avoid errors or add an explicit @return annotation to suppress this message.
User Deprecated: Method "Iterator::next()" might add "void" as a native return type declaration in the future. Do the same in implementation "Aws\ResultPaginator" now to avoid errors or add an explicit @return annotation to suppress this message.
User Deprecated: Method "Iterator::valid()" might add "bool" as a native return type declaration in the future. Do the same in implementation "Aws\ResultPaginator" now to avoid errors or add an explicit @return annotation to suppress this message.
User Deprecated: Method "Iterator::rewind()" might add "void" as a native return type declaration in the future. Do the same in implementation "Aws\ResultPaginator" now to avoid errors or add an explicit @return annotation to suppress this message.

Reproduction Steps

Just run any tests with Symfony 5.4

Possible Solution

No response

Additional Information/Context

No response

SDK version used

3.262.1

Environment details (Version of PHP (php -v)? OS name and version, etc.)

PHP 7.4.33

@Spawnrad Spawnrad added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Mar 27, 2023
@yenfryherrerafeliz yenfryherrerafeliz self-assigned this Mar 30, 2023
@yenfryherrerafeliz yenfryherrerafeliz added investigating This issue is being investigated and/or work is in progress to resolve the issue. p2 This is a standard priority issue and removed needs-triage This issue or PR still needs to be triaged. labels Mar 30, 2023
@zerkms
Copy link

zerkms commented Jul 5, 2023

These warnings come from Aws\ResultPaginator and the trivial fix is to add typing to phpdoc for the methods (like it was done here already: #2434)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. investigating This issue is being investigated and/or work is in progress to resolve the issue. p2 This is a standard priority issue
Projects
None yet
Development

No branches or pull requests

3 participants