Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Deploy Lambdas with concurrency #7056

Open
wmonk opened this issue May 13, 2024 · 3 comments
Open

Feature request: Deploy Lambdas with concurrency #7056

wmonk opened this issue May 13, 2024 · 3 comments
Labels
type/feature Feature request

Comments

@wmonk
Copy link

wmonk commented May 13, 2024

Describe your idea/feature/enhancement

We have 100s of lambdas. We build outside of SAM using esbuild into single files. When we deploy with SAM it zips up the code, checks the checksum against S3 and then decides whether to update the Lambda or not. This is a pretty slow process for us, and takes ~15m.

Proposal

SAM will zip + checksum + check s3 for each lambda in parallel batches, rather than 1 by 1.

@wmonk wmonk added stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. type/feature Feature request labels May 13, 2024
@mndeveci
Copy link
Contributor

Thanks for the suggestion @wmonk

For your use case, do you have same folders that is been used by different lambda functions? In that sense, we should make sure that parallel uploads won't try to upload same folder in different threads.

@mndeveci mndeveci removed the stage/needs-triage Automatically applied to new issues and PRs, indicating they haven't been looked at. label May 15, 2024
@having-fun-serverless
Copy link

@mndeveci I will try to tackle this issue, but I can't promise anything. You've stated:

make sure that parallel uploads won't try to upload the same folder in different threads

Can you explain the reason behind it?

And in general any pointers I can use to better understand how to approach this request?

@wmonk
Copy link
Author

wmonk commented May 29, 2024

Hey @mndevci, sorry for being slow, I missed the notification of your message.

We do a prebuild on our side, so each lambda has it's own directory, there wouldn't be overlap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature Feature request
Projects
None yet
Development

No branches or pull requests

3 participants