-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fail the app on missing queue #906
Comments
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want this issue to never become stale, please ask a maintainer to apply the "stalebot-ignore" label. |
Hi @LiorRabin I deployed NTH with a bogus SQS queue URL and the logs indicated that NTH did shutdown 2024/01/29 19:28:42 INF Started monitoring for events event_type=SQS_MONITOR
2024/01/29 19:28:44 WRN There was a problem monitoring for events error="AWS.SimpleQueueService.NonExistentQueue: The specified queue does not exist." event_type=SQS_MONITOR
2024/01/29 19:28:46 WRN There was a problem monitoring for events error="AWS.SimpleQueueService.NonExistentQueue: The specified queue does not exist." event_type=SQS_MONITOR
2024/01/29 19:28:48 WRN There was a problem monitoring for events error="AWS.SimpleQueueService.NonExistentQueue: The specified queue does not exist." event_type=SQS_MONITOR
2024/01/29 19:28:50 WRN There was a problem monitoring for events error="AWS.SimpleQueueService.NonExistentQueue: The specified queue does not exist." event_type=SQS_MONITOR
2024/01/29 19:28:50 WRN Stopping NTH - Duplicate Error Threshold hit.
panic: AWS.SimpleQueueService.NonExistentQueue: The specified queue does not exist. I think the Pod's |
We were not able to replicate the issue and NTH did shutdown from the logs, closing this issue. Thanks! |
Describe the feature
Fail the app on missing queue if queue mode is enabled.
Is the feature request related to a problem?
We're using NTH with
enableSqsTerminationDraining
set totrue
If we don't specify the
queueURL
correctly (or there is no queue in AWS) the application logs a warning but keeps being healthy.Why not fail the app in this case?
The text was updated successfully, but these errors were encountered: