Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail the app on missing queue #906

Closed
LiorRabin opened this issue Oct 3, 2023 · 3 comments
Closed

Fail the app on missing queue #906

LiorRabin opened this issue Oct 3, 2023 · 3 comments
Labels
stalebot-ignore To NOT let the stalebot update or close the Issue / PR

Comments

@LiorRabin
Copy link

Describe the feature
Fail the app on missing queue if queue mode is enabled.

Is the feature request related to a problem?
We're using NTH with enableSqsTerminationDraining set to true
If we don't specify the queueURL correctly (or there is no queue in AWS) the application logs a warning but keeps being healthy.
Why not fail the app in this case?

Copy link

github-actions bot commented Nov 2, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want this issue to never become stale, please ask a maintainer to apply the "stalebot-ignore" label.

@github-actions github-actions bot added the stale Issues / PRs with no activity label Nov 2, 2023
@jillmon jillmon added Type: Enhancement New feature or request stalebot-ignore To NOT let the stalebot update or close the Issue / PR and removed stale Issues / PRs with no activity labels Nov 6, 2023
@cjerad
Copy link
Contributor

cjerad commented Jan 29, 2024

Hi @LiorRabin

I deployed NTH with a bogus SQS queue URL and the logs indicated that NTH did shutdown

2024/01/29 19:28:42 INF Started monitoring for events event_type=SQS_MONITOR
2024/01/29 19:28:44 WRN There was a problem monitoring for events error="AWS.SimpleQueueService.NonExistentQueue: The specified queue does not exist." event_type=SQS_MONITOR
2024/01/29 19:28:46 WRN There was a problem monitoring for events error="AWS.SimpleQueueService.NonExistentQueue: The specified queue does not exist." event_type=SQS_MONITOR
2024/01/29 19:28:48 WRN There was a problem monitoring for events error="AWS.SimpleQueueService.NonExistentQueue: The specified queue does not exist." event_type=SQS_MONITOR
2024/01/29 19:28:50 WRN There was a problem monitoring for events error="AWS.SimpleQueueService.NonExistentQueue: The specified queue does not exist." event_type=SQS_MONITOR
2024/01/29 19:28:50 WRN Stopping NTH - Duplicate Error Threshold hit.
panic: AWS.SimpleQueueService.NonExistentQueue: The specified queue does not exist.

I think the Pod's restartPolicy is causing the NTH container to be restarted.

@LikithaVemulapalli LikithaVemulapalli removed the Type: Enhancement New feature or request label May 23, 2024
@LikithaVemulapalli
Copy link
Contributor

We were not able to replicate the issue and NTH did shutdown from the logs, closing this issue. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stalebot-ignore To NOT let the stalebot update or close the Issue / PR
Projects
None yet
Development

No branches or pull requests

4 participants