Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

imds asg target lifecycle hook #837

Open
pete911 opened this issue Jun 8, 2023 · 2 comments
Open

imds asg target lifecycle hook #837

pete911 opened this issue Jun 8, 2023 · 2 comments
Assignees
@cjerad
Labels
stalebot-ignore To NOT let the stalebot update or close the Issue / PR Type: Enhancement New feature or request

Comments

@pete911
Copy link

pete911 commented Jun 8, 2023

Describe the feature
Target lifecycle state is available through instance metadata since March 2022 - https://docs.aws.amazon.com/autoscaling/ec2/userguide/retrieving-target-lifecycle-state-through-imds.html It would be nice to enable this on aws-node-termination-handler when deployed in imds mode.

Is the feature request related to a problem?
Even though ASG Termination lifecycle hook is available in Queue processor mode, for some cases this adds additional infrastructure complexity (SQS, private link to SQS, permissions etc.), it would be nice to add this in IMDS mode as well, since it is available.

Initial pull request (tested in EKS cluster as well) is here #825
@pete911 pete911 mentioned this issue Jun 8, 2023
Open
@cjerad cjerad added the Type: Enhancement New feature or request label Jun 20, 2023
@pete911
Copy link
Author

pete911 commented Jul 17, 2023

@cjerad is this something you would like to merge? I removed staled label from the PR twice, but it has now been closed.

@jillmon jillmon added the stalebot-ignore To NOT let the stalebot update or close the Issue / PR label Jul 18, 2023
@cjerad cjerad self-assigned this Jul 25, 2023
@pete911
Copy link
Author

pete911 commented Oct 27, 2023

Hi @jillmon, @cjerad any news on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cjerad cjerad

Labels
stalebot-ignore To NOT let the stalebot update or close the Issue / PR Type: Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pete911 @jillmon @cjerad