Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(batch): missing JobStateTimeLimitActions in the JobQueue Construct #30142

Closed
1 of 2 tasks
mazyu36 opened this issue May 10, 2024 · 4 comments · Fixed by #30158
Closed
1 of 2 tasks

(batch): missing JobStateTimeLimitActions in the JobQueue Construct #30142

mazyu36 opened this issue May 10, 2024 · 4 comments · Fixed by #30158
Labels
@aws-cdk/aws-batch Related to AWS Batch effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Comments

@mazyu36
Copy link
Contributor

mazyu36 commented May 10, 2024

Describe the feature

Missing JobStateTimeLimitActions in the JobQueue Construct.

https://docs.aws.amazon.com/ja_jp/AWSCloudFormation/latest/UserGuide/aws-resource-batch-jobqueue.html#cfn-batch-jobqueue-jobstatetimelimitactions

Use Case

To react to blocked job queues.

It has been added at 2024/3.

https://aws.amazon.com/jp/blogs/hpc/introducing-new-alerts-to-help-users-detect-and-react-to-blocked-job-queues-in-aws-batch/

Proposed Solution

Add JobStateTimeLimitActions property the JobQueue Construct.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.141.0

Environment details (OS name and version, etc.)

MacOS
@mazyu36 mazyu36 added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels May 10, 2024
@github-actions github-actions bot added the @aws-cdk/aws-batch Related to AWS Batch label May 10, 2024
@pahud
Copy link
Contributor

pahud commented May 10, 2024

Hey @mazyu36 I am looking forward to all your PRs. Feel free to submit for that. Thank you.

@pahud pahud added p2 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels May 10, 2024
@sandeepkumar2810
Copy link

sandeepkumar2810 commented May 10, 2024 •
edited

Hello
Do we have any estimated timeframe for when this feature will be incorporated? Additionally, I am curious if there are alternative methods available within the AWS CDK codebase to address this issue, and seems this is also not supported with batch.CfnJobQueue Construct. Stuck and can't use this feature to cancel jobs in a runnable state via AWS CDK code.

Looking forward to your response and appreciate your assistance.

@mazyu36
Copy link
Contributor Author

mazyu36 commented May 11, 2024

I'm implementing it now. It seems to be already supported in the CfnJobQueue.

https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_batch.CfnJobQueue.html#jobstatetimelimitactions

@mazyu36 mazyu36 mentioned this issue May 12, 2024
Merged
1 task
This was referenced May 13, 2024
Closed
Closed
@mergify mergify bot closed this as completed in #30158 May 17, 2024
mergify bot pushed a commit that referenced this issue May 17, 2024
@mazyu36
feat(batch): jobStateTimeLimitActions property added (#30158)
411a58c 
### Issue # (if applicable)

Closes #30142 .

### Reason for this change

Missing property in the L2 Construct.


### Description of changes
Add  jobStateTimeLimitActions property to the JobQueue Construct.


### Description of how you validated changes
Add unit tests and integ tests.



### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions GitHub Actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-batch Related to AWS Batch effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(batch): jobStateTimeLimitActions property added mazyu36/aws-cdk
3 participants
@pahud @mazyu36 @sandeepkumar2810