Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prlint: assess needs review after codebuild job succeeds #30128

Open
kaizencc opened this issue May 9, 2024 · 0 comments
Open

prlint: assess needs review after codebuild job succeeds #30128

kaizencc opened this issue May 9, 2024 · 0 comments
Labels
bug This issue is a bug. effort/small Small work item – less than a day of effort p2 package/tools Related to AWS CDK Tools or CLI

Comments

@kaizencc
Copy link
Contributor

kaizencc commented May 9, 2024

Describe the bug

We refuse to assess if a PR needs review if the codebuild job is not successful. However if the pr linter runs before the codebuild job is done, it will not run again until another triggering action happens on the PR. So a situation like this might happen:

  1. open a PR
  2. community approves
  3. build reports successful

We would like this situation to still get labeled needs-maintainer-review after the build is successful, but instead it will not report anything until the next trigger.

Expected Behavior

see above

Current Behavior

see above

Reproduction Steps

see above

Possible Solution

We need the codebuild job to trigger the pr linter somehow. A possible solution is to modify the github workflow to trigger on issue_comment as well, and filter comments for the specific one that comes from aws-cdk-automation when the build succeeds. However, this likely opens prlinter to run on all prs and issues, albeit it will skip all jobs for non prs. That might be non tenable.

Alternatively, we can finangle the codebuild step to hit one of the PR triggers when successful, like adding a new label.

Additional Information/Context

No response

CDK CLI Version

2.x

Framework Version

No response

Node.js Version

20

OS

Mac

Language

TypeScript

Language Version

No response

Other information

No response

@kaizencc kaizencc added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels May 9, 2024
@github-actions github-actions bot added the @aws-cdk/aws-codebuild Related to AWS CodeBuild label May 9, 2024
@kaizencc kaizencc changed the title (module name): (short issue description) prlint: assess needs review after codebuild job succeeds May 9, 2024
@kaizencc kaizencc added p2 package/tools Related to AWS CDK Tools or CLI effort/small Small work item – less than a day of effort and removed @aws-cdk/aws-codebuild Related to AWS CodeBuild needs-triage This issue or PR still needs to be triaged. labels May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. effort/small Small work item – less than a day of effort p2 package/tools Related to AWS CDK Tools or CLI
Projects
None yet
Development

No branches or pull requests

1 participant