custom-resources: PR:29648 caused Custom resources to be replaced

[p3tek]

Describe the bug

the following PR - #29648 added an additional "logApiResponseData":true to the custom resource properties.

This triggered a replacement of existing custom resources which is not a good outcome for "onCreate" resources that are only meant to be executed once

Expected Behavior

Not have existing custom-resources replaced with this update.

Current Behavior

"logApiResponseData":true was not present prior to this PR and the custom resource was not triggered on stack update

Reproduction Steps

will trigger after an update of aws-cdk-lib

Possible Solution

allow this value to be suppressed so it doesn't trigger a resource replacement ?

Additional Information/Context

No response

CDK CLI Version

2.138.0

Framework Version

2.138.0

Node.js Version

18.16.1

OS

linux

Language

TypeScript

Language Version

No response

Other information

No response

[khushail]

Hi @p3tek , could you please share the minimum reproducible code for repro of the issue.

[colifran]

Hey @p3tek, thanks for raising this. From what I'm seeing the problem isn't necessarily the new event property being passed. What I mean is that any change we make to the underlying handler code (new property or not) will also trigger an update since it will force a change in the asset hash. This would lock us into a situation where we are unable to make any code changes because they would all force an update. Are you able to just duplicate whatever SDK call you're making for onUpdate so that you keep the same behavior in the event of an update?