Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-dynamodb: OnDemandThroughput configuration #30091

Open
1 of 2 tasks
LeeroyHannigan opened this issue May 7, 2024 · 1 comment · May be fixed by #30097
Open
1 of 2 tasks

aws-dynamodb: OnDemandThroughput configuration #30091

LeeroyHannigan opened this issue May 7, 2024 · 1 comment · May be fixed by #30097
Labels
@aws-cdk/aws-dynamodb Related to Amazon DynamoDB effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@LeeroyHannigan
Copy link

Describe the feature

Sets the maximum number of read and write units for the specified on-demand table. If you use this property, you must specify MaxReadRequestUnits, MaxWriteRequestUnits, or both.

https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-dynamodb-table.html#cfn-dynamodb-table-ondemandthroughput

Use Case

New DynamoDB feature not yet implemented in CDK

Proposed Solution

Include the new parameters as soon as CFN is updated to the current version

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.122.0

Environment details (OS name and version, etc.)

MacOS
@LeeroyHannigan LeeroyHannigan added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels May 7, 2024
@github-actions github-actions bot added the @aws-cdk/aws-dynamodb Related to Amazon DynamoDB label May 7, 2024
@go-to-k
Copy link
Contributor

go-to-k commented May 7, 2024 •
edited

Thanks for this issue.
It would be great if you (or someone) could address both of these: AWS::DynamoDB::GlobalTable (Table V2 Construct) and AWS::DynamoDB::Table (Table Construct). I think that we are fine with these updates in separate issues (PRs) or together.

These have already been added to the L1 Constructs: #30074 .

├[~] service aws-dynamodb
│ └ resources
│    ├[~] resource AWS::DynamoDB::GlobalTable
│    │ ├ properties
│    │ │  └[+] WriteOnDemandThroughputSettings: WriteOnDemandThroughputSettings
│    │ └ types
│    │    ├[~] type GlobalSecondaryIndex
│    │    │ └ properties
│    │    │    └[+] WriteOnDemandThroughputSettings: WriteOnDemandThroughputSettings
│    │    ├[+] type ReadOnDemandThroughputSettings
│    │    │ ├  name: ReadOnDemandThroughputSettings
│    │    │ └ properties
│    │    │    └MaxReadRequestUnits: integer
│    │    ├[~] type ReplicaGlobalSecondaryIndexSpecification
│    │    │ └ properties
│    │    │    └[+] ReadOnDemandThroughputSettings: ReadOnDemandThroughputSettings
│    │    ├[~] type ReplicaSpecification
│    │    │ └ properties
│    │    │    └[+] ReadOnDemandThroughputSettings: ReadOnDemandThroughputSettings
│    │    └[+] type WriteOnDemandThroughputSettings
│    │      ├  name: WriteOnDemandThroughputSettings
│    │      └ properties
│    │         └MaxWriteRequestUnits: integer
│    └[~] resource AWS::DynamoDB::Table
│      ├ properties
│      │  └[+] OnDemandThroughput: OnDemandThroughput
│      └ types
│         ├[~] type GlobalSecondaryIndex
│         │ └ properties
│         │    └[+] OnDemandThroughput: OnDemandThroughput
│         └[+] type OnDemandThroughput
│           ├  name: OnDemandThroughput
│           └ properties
│              ├MaxReadRequestUnits: integer
│              └MaxWriteRequestUnits: integer

@khushail khushail added investigating This issue is being investigated and/or work is in progress to resolve the issue. p2 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. investigating This issue is being investigated and/or work is in progress to resolve the issue. labels May 7, 2024
@LeeroyHannigan LeeroyHannigan linked a pull request May 7, 2024 that will close this issue
Open
1 task
This was referenced May 13, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-dynamodb Related to Amazon DynamoDB effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: adding on-demandthroughput to table construct LeeroyHannigan/aws-cdk
3 participants
@go-to-k @LeeroyHannigan @khushail