Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(neptune): copyTagsToSnapshot is missing in the DatabaseCluster Construct #30087

Open
1 of 2 tasks
mazyu36 opened this issue May 7, 2024 · 1 comment · May be fixed by #30092
Open
1 of 2 tasks

(neptune): copyTagsToSnapshot is missing in the DatabaseCluster Construct #30087

mazyu36 opened this issue May 7, 2024 · 1 comment · May be fixed by #30092
Labels
@aws-cdk/aws-neptune Related Amazon Neptune effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 pr/needs-review

Comments

@mazyu36
Copy link
Contributor

mazyu36 commented May 7, 2024

Describe the feature

In the DatabaseCluster Construct, copyTagsToSnapshot is missing.

Use Case

Use this when you want to copy tags to snapshots.

Proposed Solution

Add copyTagsToSnapshot to the DatabaseCluster Construct.

const cluster = new neptune.DatabaseCluster(this, 'Database', {
  vpc,
  instanceType: neptune.InstanceType.R5_LARGE,
  copyTagsToSnapshot: true, // Add
});

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.140.0

Environment details (OS name and version, etc.)

MacOS

@mazyu36 mazyu36 added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels May 7, 2024
@github-actions github-actions bot added the @aws-cdk/aws-neptune Related Amazon Neptune label May 7, 2024
@ashishdhingra ashishdhingra self-assigned this May 7, 2024
@ashishdhingra ashishdhingra added investigating This issue is being investigated and/or work is in progress to resolve the issue. p2 effort/small Small work item – less than a day of effort pr/needs-review and removed needs-triage This issue or PR still needs to be triaged. investigating This issue is being investigated and/or work is in progress to resolve the issue. labels May 7, 2024
@ashishdhingra
Copy link
Contributor

@mazyu36 Thanks for your PR contribution.

@ashishdhingra ashishdhingra removed their assignment May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-neptune Related Amazon Neptune effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 pr/needs-review
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants