-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(ivs-alpha): support advanced channel type #30075
Labels
@aws-cdk/aws-ivs
Related to Amazon IVS
effort/small
Small work item – less than a day of effort
feature-request
A feature should be added or improved.
p2
Comments
mazyu36
added
feature-request
A feature should be added or improved.
needs-triage
This issue or PR still needs to be triaged.
labels
May 6, 2024
mazyu36
changed the title
(ivs): support advanced channel type
(ivs-alpha): support advanced channel type
May 6, 2024
ashishdhingra
added
investigating
This issue is being investigated and/or work is in progress to resolve the issue.
and removed
needs-triage
This issue or PR still needs to be triaged.
labels
May 6, 2024
@mazyu36 Feel free to contribute a PR for this feature request which could be reviewed by the team. Thanks, |
ashishdhingra
added
p2
effort/small
Small work item – less than a day of effort
and removed
investigating
This issue is being investigated and/or work is in progress to resolve the issue.
labels
May 6, 2024
1 task
This was referenced May 13, 2024
mergify bot
pushed a commit
that referenced
this issue
May 24, 2024
### Issue # (if applicable) Closes #30075 ### Reason for this change As described in the issue. ### Description of changes * Add `ADVANCED_HD` and `ADVANCED_SD` to the `ivs.ChannelType`. * Add `preset` property to the Channel Construct. Additionally, validation has been implemented to allow setting the preset property only when using the Advanced channel type ### Description of how you validated changes Add both unit tests and integ tests. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
atanaspam
pushed a commit
to atanaspam/aws-cdk
that referenced
this issue
Jun 3, 2024
### Issue # (if applicable) Closes aws#30075 ### Reason for this change As described in the issue. ### Description of changes * Add `ADVANCED_HD` and `ADVANCED_SD` to the `ivs.ChannelType`. * Add `preset` property to the Channel Construct. Additionally, validation has been implemented to allow setting the preset property only when using the Advanced channel type ### Description of how you validated changes Add both unit tests and integ tests. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
@aws-cdk/aws-ivs
Related to Amazon IVS
effort/small
Small work item – less than a day of effort
feature-request
A feature should be added or improved.
p2
Describe the feature
Amazon IVS has been supporting advanced channel types since June 2023.
However, the current Channel Construct only supports BASIC and STANDARD channel types.
See:
https://aws.amazon.com/about-aws/whats-new/2023/06/amazon-ivs-advanced-channel-types-input-encoding/?nc1=h_ls
Use Case
To use advanced channel types using CDK.
Proposed Solution
ADVANCED_HD
andADVANCED_SD
to theChannelType
.preset
property to theChannel
Construct. Additionally, implement validation according to the following:See: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-ivs-channel.html#cfn-ivs-channel-preset
Other Information
No response
Acknowledgements
CDK version used
2.140.0
Environment details (OS name and version, etc.)
MacOS
The text was updated successfully, but these errors were encountered: