Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable target group port #619

Open
johnstaf144 opened this issue Apr 17, 2024 · 1 comment
Open

Configurable target group port #619

johnstaf144 opened this issue Apr 17, 2024 · 1 comment

Comments

@johnstaf144
Copy link

Currently, all VPC Lattice target groups are created with the target group port as 80 which is not configurable.

Reference:

Could we change this so that we can configure the target group port, possibly using the TargetGroupPolicy. It could look something like:

kind: TargetGroupPolicy
metadata:
    name: test-policy
spec:
    targetRef:
        group: ""
        kind: Service
        name: my-parking-service
    port: 8080 # new attribute proposal

and if port is not supplied it can use the current default of 80 for backwards compatibility. If this proposal is accepted I'm happy to attempt a PR for the change.

Many thanks

@erikfuller
Copy link
Contributor

Hi @johnstaf144, thanks for opening this issue.

The port used at target group creation is basically just a placeholder, it isn't actually used for routing traffic. When we register the targets, we specify the port that is actually used. This logic exists in model_build_targets.go.

Was there another reason behind needing to specify this port value?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants