Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate helm chart with Cert-Manager CA Injector #618

Open
phmcder opened this issue Apr 16, 2024 · 1 comment
Open

Integrate helm chart with Cert-Manager CA Injector #618

phmcder opened this issue Apr 16, 2024 · 1 comment
Labels
enhancement New feature or request small

Comments

@phmcder
Copy link

phmcder commented Apr 16, 2024

The current Helm chart requires the passing of TLS certificate values. Then it will create the certificate secret and hard code the caCert value for the webhook.

Other helm deployments have the option of using Cert-Manager to manage the webhook certificates using the CA Injector. This automates the updating of the webhook caCert value. https://cert-manager.io/docs/concepts/ca-injector/

External-Secrets has a helm chart that supports this:
Here the cert-manager.io/inject-ca-fromannotation is being set on line 12 (https://github.com/external-secrets/external-secrets/blob/main/deploy/charts/external-secrets/templates/validatingwebhook.yaml)

Currently, I am blocked from implementing this because

  • The MutatingWebhookConfiguration yaml does not allow me to add annotations in /helm/templates/webhook.yaml
  • the webhooks.clientConfig.caBundle value is not optional in /helm/templates/webhook.yaml
  • The creation of the webhook-cert is not optional in /helm/templates/webhook.yaml

Can Cert-Manager support be added to the Helm?

Thanks

@erikfuller
Copy link
Contributor

Hi @phmcder, thanks for opening this issue. What's in the AWS load balancer controller would adapt well to our Helm chart (webhook annotation, secret/cert, and volume).

Adding cert-manager support makes sense, though the timeline to address would likely depend on demand. Happy to review a PR as well if you'd like to accelerate this.

@erikfuller erikfuller added enhancement New feature or request small labels May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request small
Projects
None yet
Development

No branches or pull requests

2 participants