You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
AccessLogPolicy CRD allows to create multiple k8s resources with same TargetRef. We use multiple policies to create different kind of subscriptions like Cloudwatch, Firehose, etc. Each creates new k8s resource.
But it contradicts GEP-713 spec for conflicting policies. We implemented AccessLogPolicy with GEP in mind. GEP says that only one policy of particular type (CRD) should be valid, others should be marked as conflicting.
I think we should refactor CRD. CRD's Spec should include list of subscriptions and their types, rather than creating multiple k8s resources for each subscription.
The text was updated successfully, but these errors were encountered:
mikhail-aws
changed the title
AccessLogPolicy does not follow Policy Attachment (GEP-713) for conflictring policies
AccessLogPolicy does not follow Policy Attachment (GEP-713) for conflicting policies
Dec 4, 2023
AccessLogPolicy CRD allows to create multiple k8s resources with same TargetRef. We use multiple policies to create different kind of subscriptions like Cloudwatch, Firehose, etc. Each creates new k8s resource.
But it contradicts GEP-713 spec for conflicting policies. We implemented AccessLogPolicy with GEP in mind. GEP says that only one policy of particular type (CRD) should be valid, others should be marked as conflicting.
I think we should refactor CRD. CRD's Spec should include list of subscriptions and their types, rather than creating multiple k8s resources for each subscription.
The text was updated successfully, but these errors were encountered: