Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AccessLogPolicy does not follow Policy Attachment (GEP-713) for conflicting policies #559

Open
mikhail-aws opened this issue Dec 4, 2023 · 0 comments

Comments

@mikhail-aws
Copy link
Contributor

mikhail-aws commented Dec 4, 2023

AccessLogPolicy CRD allows to create multiple k8s resources with same TargetRef. We use multiple policies to create different kind of subscriptions like Cloudwatch, Firehose, etc. Each creates new k8s resource.

But it contradicts GEP-713 spec for conflicting policies. We implemented AccessLogPolicy with GEP in mind. GEP says that only one policy of particular type (CRD) should be valid, others should be marked as conflicting.

I think we should refactor CRD. CRD's Spec should include list of subscriptions and their types, rather than creating multiple k8s resources for each subscription.

@mikhail-aws mikhail-aws changed the title AccessLogPolicy does not follow Policy Attachment (GEP-713) for conflictring policies AccessLogPolicy does not follow Policy Attachment (GEP-713) for conflicting policies Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant