Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pagination to GetAccounts query #402

Open
svozza opened this issue Mar 18, 2023 · 0 comments
Open

Add Pagination to GetAccounts query #402

svozza opened this issue Mar 18, 2023 · 0 comments
Labels
enhancement New feature or request triaged Has been triaged by solutions team

Comments

@svozza
Copy link
Contributor

svozza commented Mar 18, 2023

After implementing the AWS Organization integration, there will be users who may have thousands of accounts in their org that will be imported by the discovery process. This greatly increases the chance that we will exceed the lambda payload limit when returning the list of accounts on the frontend. As the accounts are store in DynamoDB we cannot use the same pagination strategy as our other APIs and must instead use LastEvaluatedKey field detailed in the DynamoDB docs. This will impact on #396, as moving the organizations:ListAccounts API calls to the Settings lambda could cause rate limiting issues when calling that API repeated during paged requests.

@svozza svozza added enhancement New feature or request triaged Has been triaged by solutions team labels Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triaged Has been triaged by solutions team
Projects
None yet
Development

No branches or pull requests

1 participant