Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 Bucket Name is Empty when deploying UI Bucket #450

Open
gknorman-amazon opened this issue Apr 10, 2024 · 4 comments
Open

S3 Bucket Name is Empty when deploying UI Bucket #450

gknorman-amazon opened this issue Apr 10, 2024 · 4 comments

Comments

@gknorman-amazon
Copy link

I tried deploying today with minimal input (with a private website only accessible in a VPC) during the config process, but the deployed CFN had an empty string for the S3 Bucket Name for the UI hosting bucket:

"UserInterfaceWebsiteBucket2BDEA247": {
"Type": "AWS::S3::Bucket",
"Properties": {
"BucketName": "",
"LoggingConfiguration": {
"DestinationBucketName": {
"Ref": "UserInterfaceWebsiteLogsBucket54728780"
}
}

I didn't provide a certificate ARN nor a domain name, and I'm not sure if these are necessary to generate the Bucket Name, but I expected there to be an explicit step to name the bucket during configuration if input is actually needed from the user.

@gknorman-amazon
Copy link
Author

In the meantime, I'll fix this the "wrong" way by creating a default bucket name in case the domain name is left empty during the config process in user-interface/index.ts

const defaultBucketNameString = "website-bucket" + cdk.Stack.of(this).account + "-" + cdk.Stack.of(this).region;

const defaultDomainName = props.config.domain ? props.config.domain : defaultBucketNameString;

If I enter my own domain name but I haven't set up my own hosted zone, etc already, will it create it for me? If so, I feel very silly and would ask for an update in config process or the documentation to make us aware of this.

@Rob-Powell
Copy link
Contributor

As per the docs you need to do the pre req steps and then pass those values to the installer:

https://aws-samples.github.io/aws-genai-llm-chatbot/documentation/private-chatbot.html

@gknorman-amazon
Copy link
Author

Can these prereqs be shown / linked to on the Deployment Guide page then?

This is the first time seeing this "Private Chatbot" page since I went straight from the "The Project" page and the "Deployment Guide" link at the bottom of that page. I didn't realize there were any prereqs when I started the Cloud 9 deployment steps.

@Rob-Powell
Copy link
Contributor

They are linked to on the left hand side navigation. but there should be validation on those fields in config creation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

2 participants