Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre-commit updates to 1.2.5.a8 instead of 0.87.1 #3219

Open
whoDoneItAgain opened this issue May 6, 2024 · 7 comments
Open

pre-commit updates to 1.2.5.a8 instead of 0.87.1 #3219

whoDoneItAgain opened this issue May 6, 2024 · 7 comments

Comments

@whoDoneItAgain
Copy link
Contributor

CloudFormation Lint Version

0.86.4

What operating system are you using?

windows

Describe the bug

updating the pre-commit configuration for cfn-lint via pre-commit autoupdate go to the v1.2.5a8 instead of the current version of v0.87.1

Expected behavior

updates to (as of today) v0.87.1

Reproduction template

n/a

@whoDoneItAgain
Copy link
Contributor Author

same thing is happening even with the new v0.87.2 release. Only thing i can see different between 1.2.5a8 and the other alphas is it's tag doesnt have the precedding 'v'.

its version 1.2.5.a8 unlike the others v1.2.5.a7 or v0.87.2

@kddejong
Copy link
Contributor

Can you show me the cfn-lint pre-commit? I can't replicate this issue with the following configuration.

repos:
  - repo: https://github.com/aws-cloudformation/cfn-lint
    rev: v0.87.1 # The version of cfn-lint to use
    hooks:
      - id: cfn-lint
        files: templates/.*\.(json|yml|yaml)$

@kddejong
Copy link
Contributor

I got it autoupdate is doing it... looking into it.

@kddejong
Copy link
Contributor

pre-commit autoupdate works by picking the latest revision on the main branch. Unfortunately as we migrate to v1 this has adjusted. While the v0 branch is still there we can't tell pre-commit to switch the branch to pull the latest tag for.

@kddejong
Copy link
Contributor

@whoDoneItAgain
Copy link
Contributor Author

that makes sense and understand that it pulls the latest. Did something change with the v1 alpha 8 release? I have gitflow workflow action that runs every 2 hours or so to run pre-commit autoupdate and open a PR for me. Up until, alpha 8's release, the action always used the latest, non pre-release tag. whatever release showed in the release widget of the repo
image

@whoDoneItAgain
Copy link
Contributor Author

I see what you're saying now. I didn't see that you moved the old v1 branch to main and moved the old main branch to v0 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants